Skip to content

Brussels| 25-ITP-Dec | Julie Danjou | flows challenges unit testing katas tdd#53

Open
serotonine wants to merge 15 commits intoHackYourFutureBelgium:mainfrom
serotonine:data-flows-challenges-unit-testing-katas-tdd
Open

Brussels| 25-ITP-Dec | Julie Danjou | flows challenges unit testing katas tdd#53
serotonine wants to merge 15 commits intoHackYourFutureBelgium:mainfrom
serotonine:data-flows-challenges-unit-testing-katas-tdd

Conversation

@serotonine
Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@muridabuhamed
Copy link
Copy Markdown

Heelloooo

EX1 : Excellent
Ex2: logical issue you are checking for teachers with pets only inside the Gryffindor condition. the code only finds Gryffindor teachers with pets, not all teachers with pets. so should be separate

if (house === "Gryffindor") {
gryffindor += text;
}

if (occupation === "Teacher" && pet) {
teacherWithPet += text;
}

Ex3 : Excellent work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants